Prereq: "3.4.12" diff -ur --new-file /var/tmp/postfix-3.4.12/src/global/mail_version.h ./src/global/mail_version.h --- /var/tmp/postfix-3.4.12/src/global/mail_version.h 2020-05-16 12:01:12.000000000 -0400 +++ ./src/global/mail_version.h 2020-06-14 16:43:07.000000000 -0400 @@ -20,8 +20,8 @@ * Patches change both the patchlevel and the release date. Snapshots have no * patchlevel; they change the release date only. */ -#define MAIL_RELEASE_DATE "20200516" -#define MAIL_VERSION_NUMBER "3.4.12" +#define MAIL_RELEASE_DATE "20200614" +#define MAIL_VERSION_NUMBER "3.4.13" #ifdef SNAPSHOT #define MAIL_VERSION_DATE "-" MAIL_RELEASE_DATE diff -ur --new-file /var/tmp/postfix-3.4.12/HISTORY ./HISTORY --- /var/tmp/postfix-3.4.12/HISTORY 2020-05-16 16:25:06.000000000 -0400 +++ ./HISTORY 2020-06-10 17:18:40.000000000 -0400 @@ -24412,3 +24412,18 @@ session may cause a false 'lost connection' error for a concurrent TLS session in the same tlsproxy process. File: tlsproxy/tlsproxy.c. + +20200530 + + Bugfix (introduced: Postfix 3.1): "postfix tls deploy-server-cert" + did not handle a missing optional argument. File: + conf/postfix-tls-script. + +20200610 + + Bugfix (introduced: Postfix 3.4): in the Postfix SMTP server, + the SNI callback reported an error when it was called a + second time. This happened after the server-side TLS engine + sent a TLSv1.3 HelloRetryRequest (HRR) to a remote SMTP + client. Reported by Ján Máté, fixed by Viktor Dukhovni. + File: tls/tls_misc.c. diff -ur --new-file /var/tmp/postfix-3.4.12/conf/postfix-tls-script ./conf/postfix-tls-script --- /var/tmp/postfix-3.4.12/conf/postfix-tls-script 2017-02-18 20:58:20.000000000 -0500 +++ ./conf/postfix-tls-script 2020-05-30 10:37:04.000000000 -0400 @@ -777,7 +777,7 @@ deploy_server_cert() { certfile=$1; shift keyfile=$1; shift - deploy=$1; shift + case $# in 0) deploy=;; *) deploy=$1; shift;; esac # Sets key_algo, key_param and cert_param check_key "$keyfile" || return 1 diff -ur --new-file /var/tmp/postfix-3.4.12/src/tls/tls_misc.c ./src/tls/tls_misc.c --- /var/tmp/postfix-3.4.12/src/tls/tls_misc.c 2019-06-25 17:51:24.000000000 -0400 +++ ./src/tls/tls_misc.c 2020-06-10 17:16:49.000000000 -0400 @@ -686,6 +686,27 @@ TLScontext->namaddr, sni); return SSL_TLSEXT_ERR_NOACK; } + + /* + * With TLS 1.3, when the client's proposed key share is not supported by + * the server, the server may issue a HelloRetryRequest (HRR), and the + * client will then retry with a new key share on a curve supported by + * the server. This results in the SNI callback running twice for the + * same connection. + * + * When that happens, The client MUST send the essentially the same hello + * message, including the SNI name, and since we've already loaded our + * certificate chain, we don't need to do it again! Therefore, if we've + * already recorded the peer SNI name, just check that it has not + * changed, and return success. + */ + if (TLScontext->peer_sni) { + if (strcmp(sni, TLScontext->peer_sni) == 0) + return SSL_TLSEXT_ERR_OK; + msg_warn("TLS SNI changed from %s initially %s, %s after hello retry", + TLScontext->namaddr, TLScontext->peer_sni, sni); + return SSL_TLSEXT_ERR_NOACK; + } do { /* Don't silently skip maps opened with the wrong flags. */ pem = maps_file_find(tls_server_sni_maps, cp, 0);