X-From-Line: SRS0=tyW3h3Ep=QL=perl.org=perl5-porters-return-130700-andreas.koenig=anima.de@anima.de Sun Nov 18 17:44:25 2007
X-Spam-Checker-Version: SpamAssassin 3.2.1 (2007-05-02) on k75.linux.bogus
X-Spam-Level: 
X-Spam-Status: No, score=0.1 required=6.1 tests=AWL,BAYES_50 autolearn=no
	version=3.2.1
X-Spam-Report: 
	*  0.0 BAYES_50 BODY: Bayesian spam probability is 40 to 60%
	*      [score: 0.5000]
	*  0.1 AWL AWL: From: address is in the auto white-list
Received: from mi030.mc1.hosteurope.de (mi030.mc1.hosteurope.de [80.237.138.225])
	by franz.ak.mind.de (8.13.8/8.14.1/Debian-8) with ESMTP id lAIGiPSC017458
	for <ak-anima@franz.ak.mind.de>; Sun, 18 Nov 2007 17:44:25 +0100
Received: from x6.develooper.com ([63.251.223.186] helo=lists.develooper.com)
	by mx0.webpack.hosteurope.de (mi030.mc1.hosteurope.de) using smtp
	id 1ItnFv-00076p-3Z
	for andreas.koenig@anima.de; Sun, 18 Nov 2007 17:44:24 +0100
Received: (qmail 28159 invoked by uid 514); 18 Nov 2007 16:44:20 -0000
Mailing-List: contact perl5-porters-help@perl.org; run by ezmlm
Precedence: bulk
list-help: <mailto:perl5-porters-help@perl.org>
list-unsubscribe: <mailto:perl5-porters-unsubscribe@perl.org>
list-post: <mailto:perl5-porters@perl.org>
X-List-Archive: <http://nntp.perl.org/group/perl.perl5.porters/130700>
List-Id: <perl5-porters.perl.org>
Delivered-To: mailing list perl5-porters@perl.org
Received: (qmail 28144 invoked from network); 18 Nov 2007 16:44:20 -0000
Delivered-To: perl5-porters@perl.org
X-Authentication-Warning: biokovo-amd64.herceg.de: eserte set sender to slaven@rezic.de using -f
Sender: eserte@biokovo-amd64.herceg.de
To: David Cantrell <david@cantrell.org.uk>
Cc: perl5-porters@perl.org, msergeant@cpan.org
Subject: Re: Carp::Heavy is being bizarre
References: <20071117233558.GA28925@bytemark.barnyard.co.uk>
Reply-to: slaven@rezic.de
From: Slaven Rezic <slaven@rezic.de>
X-Mailer: GNU Emacs/sendmail [version 21.3.1]
Date: 18 Nov 2007 17:20:53 +0100
In-Reply-To: <20071117233558.GA28925@bytemark.barnyard.co.uk>
X-Gnus-Mail-Source: directory:~/Mail/spool/
Message-ID: <87wssfed96.fsf@biokovo-amd64.herceg.de>
User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-HE-Spam-Level: --------
X-Filter: mailagent [version 3.0 PL73] for andreas.koenig@anima.de
Lines: 48
Xref: k75.linux.bogus perl5-porters:134569

David Cantrell <david@cantrell.org.uk> writes:

> The XML-Parser Makefile.PL is spitting this out:
>   http://www.nntp.perl.org/group/perl.cpan.testers/2007/11/msg777810.html
> 
> > ERROR from evaluation of
> > /home/david/_/_/perl-5.8.8/.cpan/build/XML-Parser-2.35-3AYyMO/Expat/Makefile.PL:
> > Bizarre copy of ARRAY in sassign at
> > /home/david/cpantesting/perl-5.8.8/lib/5.8.8/Carp/Heavy.pm line 45.
> 
> It happens on perl 5.6.2, 5.8.8 and 5.9.5, and on numerous platforms.
> 
> I've also reported it to XML-Parser's author, but Carp::Heavy is a p5p
> thang.  I presume that whatever's triggering it is a bug in XML-Parser's
> Makefile.PL, but even so, it shouldn't be able to make Carp::Heavy fall
> over like that.
> 

The patch below fixes the problem. Both Makefile.PL's have a global
@extras in the same namespace defined. Maybe, to be on the safe side,
all variables should be turned into lexicals.

Regards,
    Slaven

#### Patch data follows ####
diff -up 'XML-Parser-2.35-UptGou/Makefile.PL' 'XML-Parser-2.35-vZQ5vb/Makefile.PL'
Index: ./Makefile.PL
--- ./Makefile.PL	Fri Nov 16 21:23:42 2007
+++ ./Makefile.PL	Sun Nov 18 17:11:32 2007
@@ -85,7 +85,7 @@ sub MY::test
   $ret;
 }
 
-@extras = ();
+my @extras = ();
 
 push(@extras,
      CAPI => 'TRUE')
#### End of Patch data ####


-- 
Slaven Rezic - slaven <at> rezic <dot> de

    tknotes - A knotes clone, written in Perl/Tk.
    http://ptktools.sourceforge.net/#tknotes